Abacn commented on code in PR #24770:
URL: https://github.com/apache/beam/pull/24770#discussion_r1059146903
##########
.test-infra/tools/stale_bq_datasets_cleaner.sh:
##########
@@ -33,11 +34,13 @@ for dataset in ${BQ_DATASETS[@]}; do
if [[ $dataset =~ $template ]]; then
# The BQ API reports LAST MODIFIED TIME in miliseconds, while unix works
in seconds since epoch
# thus why we need to convert to seconds.
- LAST_MODIFIED_MS=`bq --format=json --project_id=$PROJECT show $dataset |
jq -r .lastModifiedTime`
+ [[ `bq --format=json --project_id=$PROJECT show $dataset` =~
\"lastModifiedTime\":\"([0-9]+)\" ]]
+ LAST_MODIFIED_MS=${BASH_REMATCH[1]}
LAST_MODIFIED=$(($LAST_MODIFIED_MS / 1000))
if [[ $GRACE_PERIOD -gt $LAST_MODIFIED ]]; then
- echo "Deleting $dataset (modified `date -d @$LAST_MODIFIED`) Command
bq --project_id=$PROJECT rm -r -f $dataset"
- bq --project_id=$PROJECT rm -r -f $dataset
+ echo "Deleting $dataset (modified `date -d @$LAST_MODIFIED`)"
+ # do not fail the script if delete dataset fail
+ bq --project_id=$PROJECT rm -r -f $dataset || true
Review Comment:
<img width="415" alt="image"
src="https://user-images.githubusercontent.com/8010435/210010421-0a65f825-71f6-4926-9950-1cf7f4afff76.png";>
I suspect this happens when some user manually run an integration test whose
account has some permission setting which prevents others from deleting it.
Even if these dataset are removed, whenever some user running integration test
and added new temp dataset, this task would fail again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
![https://user-images.githubusercontent.com/8010435/210010421-0a65f825-71f6-4926-9950-1cf7f4afff76.png"](https://user-images.githubusercontent.com/8010435/210010421-0a65f825-71f6-4926-9950-1cf7f4afff76.png"){kind=link}