damccorm commented on code in PR #24770:
URL: https://github.com/apache/beam/pull/24770#discussion_r1059151524
##########
.test-infra/tools/stale_bq_datasets_cleaner.sh:
##########
@@ -33,11 +34,13 @@ for dataset in ${BQ_DATASETS[@]}; do
if [[ $dataset =~ $template ]]; then
# The BQ API reports LAST MODIFIED TIME in miliseconds, while unix works
in seconds since epoch
# thus why we need to convert to seconds.
- LAST_MODIFIED_MS=`bq --format=json --project_id=$PROJECT show $dataset |
jq -r .lastModifiedTime`
+ [[ `bq --format=json --project_id=$PROJECT show $dataset` =~
\"lastModifiedTime\":\"([0-9]+)\" ]]
+ LAST_MODIFIED_MS=${BASH_REMATCH[1]}
LAST_MODIFIED=$(($LAST_MODIFIED_MS / 1000))
if [[ $GRACE_PERIOD -gt $LAST_MODIFIED ]]; then
- echo "Deleting $dataset (modified `date -d @$LAST_MODIFIED`) Command
bq --project_id=$PROJECT rm -r -f $dataset"
- bq --project_id=$PROJECT rm -r -f $dataset
+ echo "Deleting $dataset (modified `date -d @$LAST_MODIFIED`)"
+ # do not fail the script if delete dataset fail
+ bq --project_id=$PROJECT rm -r -f $dataset || true
Review Comment:
Probably the right fix here is to give the service account a better
permission set.
My worry if we just ignore this error is that then we entirely lose our
signal. We should be failing the job and then manually removing the resources
in that case. @lukecwik are you able to delete these? Looks like you may have
the right permission set
-
https://pantheon.corp.google.com/bigquery?q=search&referrer=search&page=dataset&p=apache-beam-testing&d=beam_temp_dataset_2fce1dad3a414c7fb0d67a35ede80272&project=apache-beam-testing&mods=dataflow_dev&orgonly=true&supportedpurview=organizationId
-
https://pantheon.corp.google.com/bigquery?q=search&referrer=search&page=dataset&p=apache-beam-testing&d=beam_temp_dataset_36fabf70b9044847b7478c27fe6a6f46&project=apache-beam-testing&mods=dataflow_dev&orgonly=true&supportedpurview=organizationId&ws=!1m4!1m3!3m2!1sapache-beam-testing!2sbeam_temp_dataset_36fabf70b9044847b7478c27fe6a6f46
-
https://pantheon.corp.google.com/bigquery?q=search&referrer=search&page=dataset&p=apache-beam-testing&d=beam_temp_dataset_8828ff4eb5e9460e9ba05811b3f344ef&project=apache-beam-testing&mods=dataflow_dev&orgonly=true&supportedpurview=organizationId&ws=!1m4!1m3!3m2!1sapache-beam-testing!2sbeam_temp_dataset_8828ff4eb5e9460e9ba05811b3f344ef
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
