alexeyinkin commented on code in PR #24865:
URL: https://github.com/apache/beam/pull/24865#discussion_r1060651045
##########
playground/frontend/lib/modules/examples/components/example_list/example_item_actions.dart:
##########
@@ -35,23 +39,14 @@ class ExampleItemActions extends StatelessWidget {
Widget build(BuildContext context) {
return Row(
children: [
- if (example.isMultiFile) multifilePopover,
+ if (example.isMultiFile) const _Icon(MultiFileIcon()),
if (example.complexity != null)
- ComplexityWidget(complexity: example.complexity!),
+ _Icon(ComplexityWidget(complexity: example.complexity!)),
descriptionPopover,
],
);
}
- Widget get multifilePopover => MultifilePopoverButton(
Review Comment:
The popover was to inform that multi-file examples are not runnable. They
are runnable now, so we do not need it anymore.
##########
playground/frontend/lib/l10n/app_en.arb:
##########
@@ -195,7 +195,7 @@
"@exampleDescription": {
"description": "Description icon label"
},
- "exampleMultifile": "Multifile example info",
+ "exampleMultifile": "Multifile",
Review Comment:
Because the icon is no longer clickable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
