alexeyinkin commented on code in PR #24865: URL: https://github.com/apache/beam/pull/24865#discussion_r1063204472
########## playground/frontend/lib/modules/examples/components/example_list/example_item_actions.dart: ########## @@ -17,12 +17,15 @@ */ import 'package:flutter/material.dart'; -import 'package:playground/modules/examples/components/description_popover/description_popover_button.dart'; -import 'package:playground/modules/examples/components/multifile_popover/multifile_popover_button.dart'; -import 'package:playground/modules/examples/models/popover_state.dart'; import 'package:playground_components/playground_components.dart'; import 'package:provider/provider.dart'; +import '../../models/popover_state.dart'; +import '../description_popover/description_popover_button.dart'; +import '../multi_file_icon.dart'; + +const double _iconSize = 30; Review Comment: 1. `+` 2. This size is for icons to look good in the list, so it is coupled with the list and not with other icons. When we refactor sizing, we will derive it from list item height or text size, but until then let's keep it simple. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
