mosche commented on code in PR #24837:
URL: https://github.com/apache/beam/pull/24837#discussion_r1062775812
##########
runners/spark/src/main/java/org/apache/beam/runners/spark/translation/MultiDoFnFunction.java:
##########
@@ -180,14 +186,14 @@ public TimerInternals timerInternals() {
DoFnRunnerWithMetrics<InputT, OutputT> doFnRunnerWithMetrics =
new DoFnRunnerWithMetrics<>(stepName, doFnRunner, metricsAccum);
- return new SparkProcessContext<>(
+ SparkProcessContext<Object, InputT, OutputT> ctx =
+ new SparkProcessContext<>(
Review Comment:
> because processor is responsible for providing correct instance of output
manager which is needed doFnRunner construction
That's more or less what I meant, you can but everything into the
constructor of the processor except the runner itself. E.g. process could look
like this then:
```
processor.process(iter, doFnRunnerWithMetrics)
```
or even as below if you pass the input iterator into the constructor as well.
```
processor.process(doFnRunnerWithMetrics)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
