reuvenlax commented on code in PR #24145:
URL: https://github.com/apache/beam/pull/24145#discussion_r1063766296
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWritesShardedRecords.java:
##########
@@ -640,6 +678,18 @@ public void process(
}
appendSplitDistribution.update(numAppends);
+ if (updatedSchemaReturned.get() != null) {
+ // Update the table schema and clear the append client.
+ if
(appendClientInfo.get().hasSchemaChanged(updatedSchemaReturned.get())) {
+ appendClientInfo.set(
+ AppendClientInfo.of(
+ updatedSchemaReturned.get(),
appendClientInfo.get().getCloseAppendClient()));
+ // TODO: invalidate?
Review Comment:
Same - I believe that put() invalidates the old value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
