reuvenlax commented on code in PR #24145:
URL: https://github.com/apache/beam/pull/24145#discussion_r1067485747
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java:
##########
@@ -364,9 +395,37 @@ void invalidateWriteStream() {
}
}
- void addMessage(StorageApiWritePayload payload) throws Exception {
+ void addMessage(
+ StorageApiWritePayload payload,
+ OutputReceiver<BigQueryStorageApiInsertError> failedRowsReceiver)
+ throws Exception {
maybeTickleCache();
ByteString payloadBytes = ByteString.copyFrom(payload.getPayload());
+ if (autoUpdateSchema) {
+ if (appendClientInfo == null) {
+ appendClientInfo = getAppendClientInfo(true, null);
+ }
+ @Nullable TableRow unknownFields = payload.getUnknownFields();
Review Comment:
unknownFields are values that were unknown to the prior conversion step.
These fields may be known to the writing step (since it gets schema updates
back from Vortex) so we can't ignore them here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
