Abacn commented on code in PR #24866:
URL: https://github.com/apache/beam/pull/24866#discussion_r1065043781
##########
sdks/python/scripts/run_pytest.sh:
##########
@@ -43,12 +48,7 @@ pytest -o junit_suite_name=${envname}_no_xdist \
--junitxml=pytest_${envname}_no_xdist.xml -m 'no_xdist' ${pytest_args}
--pyargs ${posargs}
status2=$?
-# Exit with error if no tests were run in either suite (status code 5).
Review Comment:
Is removing this block intended?
##########
sdks/python/scripts/run_pytest.sh:
##########
@@ -35,6 +35,11 @@ if [[ $pytest_args =~ "-m" ]] || [[ $posargs =~ "-m" ]]; then
exit 1
fi
+# strip leading/trailing quotes from posargs because it can get double quoted
as its passed through.
Review Comment:
Just curious, is the quotes the actual cause prevented `--ignore` to work
https://github.com/apache/beam/pull/24204#discussion_r1058662550 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
