damccorm commented on code in PR #24866:
URL: https://github.com/apache/beam/pull/24866#discussion_r1065054029
##########
sdks/python/scripts/run_pytest.sh:
##########
@@ -43,12 +48,7 @@ pytest -o junit_suite_name=${envname}_no_xdist \
--junitxml=pytest_${envname}_no_xdist.xml -m 'no_xdist' ${pytest_args}
--pyargs ${posargs}
status2=$?
-# Exit with error if no tests were run in either suite (status code 5).
Review Comment:
Yes (and I also intentionally slightly ammended the comment below) - since
some environments may not have tests in every directory and we're now only
running tests on certain directories at a given time, we need to be tolerant of
empty pytest invocations.
The original motivating example was `dataframes` tests, but I think we can
still run into this with other environments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
