lostluck commented on PR #24844: URL: https://github.com/apache/beam/pull/24844#issuecomment-1377988777
> In this instance, while no new *functions* were added, you added new *behaviors*. In this case, the test would be to fail in a way that triggers your new error message, and validate the error message has what we expect. If a test doesn't exist already, it's better to leave things better than it was before, and extend the coverage. Otherwise how can we know that it doesn't break later when some other change happens? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
