yyy1000 commented on PR #24844: URL: https://github.com/apache/beam/pull/24844#issuecomment-1378097348
> > > > In this instance, while no new _functions_ were added, you added new _behaviors_. In this case, the test would be to fail in a way that triggers your new error message, and validate the error message has what we expect. > > If a test doesn't exist already, it's better to leave things better than it was before, and extend the coverage. Otherwise how can we know that it doesn't break later when some other change happens? Thanks! Now that the serialize_test file will validate the error message, I have added some unit tests to validate that Map and Array's error message is right. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
