damondouglas commented on code in PR #24946: URL: https://github.com/apache/beam/pull/24946#discussion_r1081544553
########## playground/backend/containers/scio/Dockerfile: ########## @@ -84,4 +83,18 @@ RUN chown -R appuser:appgroup /opt/playground/backend/executable_files/ \ # Switch to appuser USER appuser +# Let sbt download files from Maven +RUN mkdir -p /tmp/sbt-initialize +WORKDIR /tmp/sbt-initialize +RUN /opt/playground/backend/new_scio_project.sh +WORKDIR /tmp/sbt-initialize/scio +RUN sbt "+compile" +WORKDIR / +RUN rm -r /tmp/sbt-initialize + +# Enable mitmproxy +ENV HTTP_PROXY="http://127.0.0.1:8081"; +ENV HTTPS_PROXY="http://127.0.0.1:8081"; +ENV SBT_OPTS="-Xmx512M -XX:+UseG1GC -XX:+UseStringDeduplication" Review Comment: Can you explain again why we need mitmproxy? I read the website briefly and it looks like a networking tool. However, aren't we achieving our networking needs using kubernetes Service and other related kinds? Can our images and the Dockerfiles that describe them serve just to ship the binary? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
