TSultanov commented on code in PR #24946:
URL: https://github.com/apache/beam/pull/24946#discussion_r1088909178
##########
playground/infrastructure/grpc_client.py:
##########
@@ -34,7 +34,7 @@ class GRPCClient:
def __init__(self, wait_for_ready=True):
use_webgrpc = os.getenv("BEAM_USE_WEBGRPC", False)
- timeout = os.getenv("GRPC_TIMEOUT", 10)
+ timeout = int(os.getenv("GRPC_TIMEOUT", 10))
Review Comment:
Files a task to do this: https://github.com/apache/beam/issues/25202. This
change seems to be outside of the scope of this PR.
##########
playground/infrastructure/grpc_client.py:
##########
@@ -34,7 +34,7 @@ class GRPCClient:
def __init__(self, wait_for_ready=True):
use_webgrpc = os.getenv("BEAM_USE_WEBGRPC", False)
- timeout = os.getenv("GRPC_TIMEOUT", 10)
+ timeout = int(os.getenv("GRPC_TIMEOUT", 10))
Review Comment:
Filed a task to do this: https://github.com/apache/beam/issues/25202. This
change seems to be outside of the scope of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
