AnandInguva commented on code in PR #24911:
URL: https://github.com/apache/beam/pull/24911#discussion_r1089072252
##########
sdks/python/tox.ini:
##########
@@ -326,3 +326,20 @@ commands =
# Run all PyTorch unit tests
# Allow exit code 5 (no tests run) so that we can run this command safely on
arbitrary subdirectories.
/bin/sh -c 'pytest -o junit_suite_name={envname}
--junitxml=pytest_{envname}.xml -n 6 -m uses_pytorch {posargs}; ret=$?; [ $ret
= 5 ] && exit 0 || exit $ret'
+
+[testenv:py{37,38,39,310}-onnx]
Review Comment:
You would need to add this to
`sdks/python/test-suites/tox/py38/build.gradle` as well.
##########
sdks/python/tox.ini:
##########
@@ -326,3 +326,20 @@ commands =
# Run all PyTorch unit tests
# Allow exit code 5 (no tests run) so that we can run this command safely on
arbitrary subdirectories.
/bin/sh -c 'pytest -o junit_suite_name={envname}
--junitxml=pytest_{envname}.xml -n 6 -m uses_pytorch {posargs}; ret=$?; [ $ret
= 5 ] && exit 0 || exit $ret'
+
+[testenv:py{37,38,39,310}-onnx]
Review Comment:
```suggestion
[testenv:py{37,38,39,310}-onnx-{113}]
```
##########
sdks/python/tox.ini:
##########
@@ -326,3 +326,20 @@ commands =
# Run all PyTorch unit tests
# Allow exit code 5 (no tests run) so that we can run this command safely on
arbitrary subdirectories.
/bin/sh -c 'pytest -o junit_suite_name={envname}
--junitxml=pytest_{envname}.xml -n 6 -m uses_pytorch {posargs}; ret=$?; [ $ret
= 5 ] && exit 0 || exit $ret'
+
+[testenv:py{37,38,39,310}-onnx]
+deps =
+ onnxruntime>=1.13.1,<=1.13.1
Review Comment:
Can we just pin `onnxruntime==1.13.1`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
