AnandInguva commented on code in PR #24911: URL: https://github.com/apache/beam/pull/24911#discussion_r1096548743
########## sdks/python/apache_beam/ml/inference/onnx_inference.py: ########## @@ -0,0 +1,149 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +from typing import Any +from typing import Callable +from typing import Dict +from typing import Iterable +from typing import Optional +from typing import Sequence +from typing import Union + +import numpy + +import onnx +import onnxruntime as ort +from apache_beam.io.filesystems import FileSystems +from apache_beam.ml.inference.base import ModelHandler +from apache_beam.ml.inference.base import PredictionResult + +__all__ = ['OnnxModelHandlerNumpy'] + +NumpyInferenceFn = Callable[ + [Sequence[numpy.ndarray], ort.InferenceSession, Optional[Dict[str, Any]]], + Iterable[PredictionResult]] + + +def _convert_to_result( Review Comment: #25200 moved this method to apache_beam/ml/inference/utils.py. Can you refactor the change to it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
