damccorm commented on code in PR #25200:
URL: https://github.com/apache/beam/pull/25200#discussion_r1089227509
##########
sdks/python/apache_beam/ml/inference/base.py:
##########
@@ -62,16 +63,40 @@
_OUTPUT_TYPE = TypeVar('_OUTPUT_TYPE')
KeyT = TypeVar('KeyT')
-PredictionResult = NamedTuple(
- 'PredictionResult', [
- ('example', _INPUT_TYPE),
- ('inference', _OUTPUT_TYPE),
- ])
+
+# We use NamedTuple to define the structure of the PredictionResult,
+# however, as support for generic NamedTuples is not available in Python
+# versions prior to 3.11, we use the __new__ method to provide default
+# values for the fields while maintaining backwards compatibility.
+class PredictionResult(NamedTuple('PredictionResult',
+ [('example', _INPUT_TYPE),
+ ('inference', _OUTPUT_TYPE),
+ ('model_id', Optional[str])])):
+ __slots__ = ()
+
+ def __new__(cls, example, inference, model_id=None):
+ return super().__new__(cls, example, inference, model_id)
+
+
PredictionResult.__doc__ = """A NamedTuple containing both input and output
from the inference."""
PredictionResult.example.__doc__ = """The input example."""
PredictionResult.inference.__doc__ = """Results for the inference on the model
for the given example."""
+PredictionResult.model_id.__doc__ = """Model ID used to run the prediction."""
Review Comment:
SGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
