TSultanov commented on code in PR #25230:
URL: https://github.com/apache/beam/pull/25230#discussion_r1093057760


##########
playground/backend/containers/java/Dockerfile:
##########
@@ -57,48 +68,30 @@ COPY --from=build /go/bin/server_java_backend 
/opt/playground/backend/
 COPY --from=build /go/src/playground/backend/configs 
/opt/playground/backend/configs/
 COPY --from=build /go/src/playground/backend/logging.properties 
/opt/playground/backend/
 COPY --from=build /go/src/playground/backend/datasets 
/opt/playground/backend/datasets/
+COPY --from=dep /pipeline-dependencies/target/dependency/ 
/opt/apache/beam/jars/
 
-# Install Beam DirectRunner
-RUN wget 
https://repo1.maven.org/maven2/org/apache/beam/beam-runners-direct-java/$BEAM_VERSION/beam-runners-direct-java-$BEAM_VERSION.jar
 &&\
-    mv beam-runners-direct-java-$BEAM_VERSION.jar 
/opt/apache/beam/jars/beam-runners-direct.jar
-# Install Beam SDK Core
-RUN wget 
https://repo1.maven.org/maven2/org/apache/beam/beam-sdks-java-core/$BEAM_VERSION/beam-sdks-java-core-$BEAM_VERSION.jar
 &&\
-    mv beam-sdks-java-core-$BEAM_VERSION.jar 
/opt/apache/beam/jars/beam-sdks-java-core.jar
 # Install Beam Examples
 RUN wget 
https://repo1.maven.org/maven2/org/apache/beam/beam-examples-java/$BEAM_VERSION/beam-examples-java-$BEAM_VERSION.jar
 &&\
     mv beam-examples-java-$BEAM_VERSION.jar 
/opt/apache/beam/jars/beam-examples-java.jar
 # Install jars for Playground graphs
 RUN wget 
https://repo1.maven.org/maven2/org/apache/beam/beam-runners-core-construction-java/$BEAM_VERSION/beam-runners-core-construction-java-$BEAM_VERSION.jar
 &&\
     mv beam-runners-core-construction-java-$BEAM_VERSION.jar 
/opt/apache/beam/jars/beam-runners-core-construction-java-$BEAM_VERSION.jar
-RUN wget 
https://repo1.maven.org/maven2/org/apache/beam/beam-model-pipeline/$BEAM_VERSION/beam-model-pipeline-$BEAM_VERSION.jar
 &&\
-    mv beam-model-pipeline-$BEAM_VERSION.jar 
/opt/apache/beam/jars/beam-model-pipeline-$BEAM_VERSION.jar
-# Install Beam SDK Core tests
+# Install jars for core tests
 RUN wget 
https://repo1.maven.org/maven2/org/apache/beam/beam-sdks-java-core/$BEAM_VERSION/beam-sdks-java-core-$BEAM_VERSION-tests.jar
 &&\
     mv beam-sdks-java-core-$BEAM_VERSION-tests.jar 
/opt/apache/beam/jars/beam-sdks-java-core-tests.jar
-# Install Hamcrest
-RUN wget 
https://repo1.maven.org/maven2/org/hamcrest/hamcrest-all/$HAMCREST_VERSION/hamcrest-all-$HAMCREST_VERSION.jar
 &&\
-    mv hamcrest-all-$HAMCREST_VERSION.jar 
/opt/apache/beam/jars/hamcrest-all.jar
-# Install JUnit
-RUN wget 
https://repo1.maven.org/maven2/junit/junit/$JUNIT_VERSION/junit-$JUNIT_VERSION.jar
 &&\
-    mv junit-$JUNIT_VERSION.jar /opt/apache/beam/jars/junit.jar
-# Install Beam Vendor gRPC
-RUN wget 
https://repo1.maven.org/maven2/org/apache/beam/beam-vendor-grpc-$GRPC_VERSION/$BEAM_VENDOR_GRPC_VERSION/beam-vendor-grpc-$GRPC_VERSION-$BEAM_VENDOR_GRPC_VERSION.jar
 &&\
-    mv beam-vendor-grpc-$GRPC_VERSION-$BEAM_VENDOR_GRPC_VERSION.jar 
/opt/apache/beam/jars/beam-vendor-grpc.jar
-# Install Kafka IO
-RUN wget 
https://repo1.maven.org/maven2/org/apache/beam/beam-sdks-java-io-kafka/$BEAM_VERSION/beam-sdks-java-io-kafka-$BEAM_VERSION.jar
 &&\
-    mv beam-sdks-java-io-kafka-$BEAM_VERSION.jar 
/opt/apache/beam/jars/beam-sdks-java-io-kafka.jar
-# Install Apache Kafka Clients
+# Install kafka client
 RUN wget 
https://repo1.maven.org/maven2/org/apache/kafka/kafka-clients/$KAFKA_CLIENTS_VERSION/kafka-clients-$KAFKA_CLIENTS_VERSION.jar
 &&\

Review Comment:
   Please add comment that we are explicitly downgrading Kafka due to provided 
version not working with our emulator



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to