damccorm commented on code in PR #25230:
URL: https://github.com/apache/beam/pull/25230#discussion_r1093588625
##########
playground/backend/containers/java/build.gradle:
##########
@@ -69,9 +69,9 @@ docker {
project.docker_image_default_repo_root)
files "./build/"
tags containerImageTags()
- buildArgs(['BASE_IMAGE': project.rootProject.hasProperty(["base-image"]) ?
- project.rootProject["base-image"] :
- "apache/beam_java8_sdk" ])
+ buildArgs(['BEAM_VERSION': project.rootProject.hasProperty(["sdk-tag"]) ?
+ project.rootProject["sdk-tag"] :
+ "2.44.0" ])
Review Comment:
Could we at least pull it out as a constant at the top of the file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
