damccorm commented on code in PR #25247:
URL: https://github.com/apache/beam/pull/25247#discussion_r1093319808
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -2534,9 +2534,13 @@ class BeamModulePlugin implements Plugin<Project> {
dependsOn setupTask
dependsOn config.startJobServer
}
- mainTask.configure{dependsOn goTask}
- cleanupTask.configure{mustRunAfter goTask}
- config.cleanupJobServer.configure{mustRunAfter goTask}
+ // CrossLanguageValidatesRunnerTask is setup under python sdk but also
runs tasks not involving
+ // python versions. set 'skipNonPythonTask' property to avoid duplicated
run of these tasks.
+ if (!(project.hasProperty('skipNonPythonTask') &&
project.skipNonPythonTask == 'true')) {
+ mainTask.configure { dependsOn goTask }
+ }
+ cleanupTask.configure { mustRunAfter goTask }
+ config.cleanupJobServer.configure { mustRunAfter goTask }
Review Comment:
Do we need to special case these as well so that they run even if we're not
depending on the goTask?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
