scwhittle commented on PR #25186: URL: https://github.com/apache/beam/pull/25186#issuecomment-1422698654
Sorry I'm used to other review systems where comments are buffered. I am working on improving the testing (figured out how with clientcall interceptor) and also refactoring things to log to default logger if this disconnects and to ensure buffer remains draining until closed to prevent deadlocks. Do you think I should make it reconnect to the worker if stream breaks and otherwise dump to previous default logmanager? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
