alexeyinkin commented on code in PR #25347:
URL: https://github.com/apache/beam/pull/25347#discussion_r1101271893
##########
playground/frontend/playground_components/lib/src/widgets/overlay/opener.dart:
##########
@@ -19,17 +19,19 @@
import 'package:flutter/material.dart';
import '../../controllers/public_notifier.dart';
-import 'dismissible.dart';
+import 'widget.dart';
void openOverlay({
required BuildContext context,
required PublicNotifier closeNotifier,
required Positioned positioned,
+ bool isDismissible = true,
Review Comment:
Why not `false`?
##########
playground/frontend/playground_components/lib/src/widgets/overlay/widget.dart:
##########
@@ -18,24 +18,27 @@
import 'package:flutter/material.dart';
-class DismissibleOverlay extends StatelessWidget {
+class BeamOverlay extends StatelessWidget {
final VoidCallback close;
final Positioned child;
+ final bool isDismissible;
- const DismissibleOverlay({
+ const BeamOverlay({
required this.close,
required this.child,
+ required this.isDismissible,
Review Comment:
Sort.
##########
playground/frontend/playground_components/lib/src/widgets/overlay/widget.dart:
##########
@@ -18,24 +18,27 @@
import 'package:flutter/material.dart';
-class DismissibleOverlay extends StatelessWidget {
+class BeamOverlay extends StatelessWidget {
final VoidCallback close;
final Positioned child;
+ final bool isDismissible;
Review Comment:
Sort.
##########
playground/frontend/playground_components/lib/src/widgets/overlay/overlays.dart:
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import 'package:flutter/material.dart';
+
+import '../../../playground_components.dart';
+
+class BeamOverlays {
+ // TODO(nausharipov) review: add label?
+ // TODO(nausharipov) review: add grey-ish background?
Review Comment:
1. No.
2. Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
