nausharipov commented on code in PR #25347:
URL: https://github.com/apache/beam/pull/25347#discussion_r1101470914
##########
playground/frontend/playground_components/lib/src/widgets/overlay/opener.dart:
##########
@@ -19,17 +19,19 @@
import 'package:flutter/material.dart';
import '../../controllers/public_notifier.dart';
-import 'dismissible.dart';
+import 'widget.dart';
void openOverlay({
required BuildContext context,
required PublicNotifier closeNotifier,
required Positioned positioned,
+ bool isDismissible = true,
Review Comment:
The current users of overlay (LoginButton and Avatar) expect it to be
dismissible. Also, it is consistent with showDialog's `bool barrierDismissible
= true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
