Abacn commented on code in PR #25410:
URL: https://github.com/apache/beam/pull/25410#discussion_r1102958623
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BatchLoads.java:
##########
@@ -471,7 +495,7 @@ public WriteResult
expandUntriggered(PCollection<KV<DestinationT, ElementT>> inp
writeSinglePartition(partitions.get(singlePartitionTag),
loadJobIdPrefixView);
List<PCollectionView<?>> sideInputsForUpdateSchema =
- Lists.newArrayList(tempLoadJobIdPrefixView);
+ Lists.newArrayList(zeroLoadJobIdPrefixView);
sideInputsForUpdateSchema.addAll(dynamicDestinations.getSideInputs());
PCollection<TableDestination> successfulMultiPartitionWrites =
Review Comment:
after leaving that comment I find using a gbk may break the use case when
the final destination table gets updated more than once, e.g. in streaming file
load. Of course careful windowing we can avoid it, however I did not look deep
into it at this moment. So far I leave the overall structure of the pipeline
unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
