ahmedabu98 commented on code in PR #25410:
URL: https://github.com/apache/beam/pull/25410#discussion_r1103018598
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BatchLoads.java:
##########
@@ -471,7 +495,7 @@ public WriteResult
expandUntriggered(PCollection<KV<DestinationT, ElementT>> inp
writeSinglePartition(partitions.get(singlePartitionTag),
loadJobIdPrefixView);
List<PCollectionView<?>> sideInputsForUpdateSchema =
- Lists.newArrayList(tempLoadJobIdPrefixView);
+ Lists.newArrayList(zeroLoadJobIdPrefixView);
sideInputsForUpdateSchema.addAll(dynamicDestinations.getSideInputs());
PCollection<TableDestination> successfulMultiPartitionWrites =
Review Comment:
> using a gbk may break the use case when the final destination table gets
updated more than once, e.g. in streaming file load
Ideally, this check would prevent that if it worked as intended:
https://github.com/apache/beam/blob/feb248a41bc7570eb8503f8788e6995e4f571e9e/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/UpdateSchemaDestination.java#L263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
