robinyqiu commented on pull request #12292: URL: https://github.com/apache/beam/pull/12292#issuecomment-660365698
Yeah that is definitely a better approach. However checking of `isDeterministic()` in `RexSimplify` (https://github.com/apache/calcite/blob/551e3f5a182a48e20586e40c378224bb63e4bfb3/core/src/main/java/org/apache/calcite/rex/RexSimplify.java#L334) is only enabled in Calcite 1.23.0 (See https://issues.apache.org/jira/browse/CALCITE-3809). So how about we use the old approach for now, and create a JIRA for updating to the new approach after we update to 1.23? (The JIRA should be marked blocked by: https://issues.apache.org/jira/browse/BEAM-9379 (we should change 1.22 to 1.23) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
