robinyqiu commented on a change in pull request #12292:
URL: https://github.com/apache/beam/pull/12292#discussion_r458552857
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java
##########
@@ -805,6 +805,9 @@ private RexNode convertSimpleValueToRexNode(TypeKind kind,
Value value) {
if (wrapperFun == null) {
ret = rexBuilder().makeApproxLiteral(new BigDecimal(val),
returnType);
} else if
(BeamBigQuerySqlDialect.DOUBLE_NAN_FUNCTION.equals(wrapperFun)) {
+ // 'https://issues.apache.org/jira/browse/BEAM-10550'
Review comment:
Usually I will make a TODO here (such that you can easily find it in the
IntelliJ TODO tab), like:
```
// TODO[BEAM-10550]: Update the temporary workaround below after vendored
Calcite version >= 1.23.0
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
