mahagen commented on code in PR #25644:
URL: https://github.com/apache/beam/pull/25644#discussion_r1134564026


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/providers/BigQueryStorageWriteApiSchemaTransformProvider.java:
##########
@@ -157,24 +160,41 @@ public static Builder builder() {
           .Builder();
     }
 
+    @SchemaFieldDescription(
+        "The bigquery table to write to. Format: 
[${PROJECT}:]${DATASET}.${TABLE}")
     public abstract String getTable();
 
+    @SchemaFieldDescription(
+        "Optional field that specifies whether the job is allowed to create 
new tables. "
+            + "The following values are supported: CREATE_IF_NEEDED (the job 
may create the table), CREATE_NEVER ("
+            + "the job must fail if the table does not exist already).")

Review Comment:
   Can we add a comment about the default? I think this was it (based on 
https://cloud.google.com/bigquery/docs/reference/rest/v2/Job), but we should 
probably test this too. 
   
   The default value is CREATE_IF_NEEDED.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to