mahagen commented on code in PR #25644:
URL: https://github.com/apache/beam/pull/25644#discussion_r1134577993


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PubsubLiteReadSchemaTransformProvider.java:
##########
@@ -137,14 +150,29 @@ public PCollectionRowTuple expand(PCollectionRowTuple 
input) {
   @AutoValue
   @DefaultSchema(AutoValueSchema.class)
   public abstract static class PubsubLiteReadSchemaTransformConfiguration {
-    public abstract String getDataFormat();
-
+    @SchemaFieldDescription(
+        "The encoding format for the data stored in Pubsub Lite. Valid options 
are: "
+            + VALID_FORMATS_STR)
+    public abstract String getFormat();
+
+    @SchemaFieldDescription(
+        "The schema in which the data is encoded in the Kafka topic. "
+            + "For AVRO data, this is a schema defined with AVRO schema syntax 
"
+            + "(https://avro.apache.org/docs/1.10.2/spec.html#schemas). "
+            + "For JSON data, this is a schema defined with JSON-schema syntax 
(https://json-schema.org/).")
     public abstract String getSchema();
 
+    @SchemaFieldDescription(
+        "The GCP project where the Pubsub Lite reservation resides. This can 
be a "
+            + "project number of a project ID.")

Review Comment:
   or a project ID.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to