mahagen commented on code in PR #25644:
URL: https://github.com/apache/beam/pull/25644#discussion_r1134580559
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaReadSchemaTransformConfiguration.java:
##########
@@ -56,24 +60,47 @@ public static Builder builder() {
}
/** Sets the bootstrap servers for the Kafka consumer. */
+ @SchemaFieldDescription(
+ "A list of host/port pairs to use for establishing the initial
connection to the"
+ + " Kafka cluster. The client will make use of all servers
irrespective of which servers are specified"
+ + " here for bootstrapping—this list only impacts the initial hosts
used to discover the full set"
+ + " of servers. This list should be in the form
`host1:port1,host2:port2,...`")
public abstract String getBootstrapServers();
@Nullable
public abstract String getConfluentSchemaRegistryUrl();
- // TODO(pabloem): Make data format an ENUM
+ @SchemaFieldDescription(
+ "The encoding format for the data stored in Kafka. Valid options are: "
+ VALID_FORMATS_STR)
Review Comment:
commas in formats str should have spaces after them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
