twang126 commented on code in PR #25935:
URL: https://github.com/apache/beam/pull/25935#discussion_r1145189143
##########
sdks/python/apache_beam/yaml/yaml_transform.py:
##########
@@ -377,6 +378,18 @@ def pipeline_as_composite(spec):
return dict(spec, name=None, type='composite')
+def normalize_source_sink(spec):
Review Comment:
This is neat, this should help keep the chain YAML parser simple (everything
is just a transform) and still exposing the `source` and `sink` keywords to the
user makes it easier for users to structure and write the actual YAMLs.
We had parsed source and sink transforms differently than others and it got
messy trying to enforce best practices across all our different classes of
transforms (sources, sinks, custom user transforms, etc) so I think this is
better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
