robertwb commented on code in PR #25935:
URL: https://github.com/apache/beam/pull/25935#discussion_r1145247987
##########
sdks/python/apache_beam/yaml/yaml_transform.py:
##########
@@ -377,6 +378,18 @@ def pipeline_as_composite(spec):
return dict(spec, name=None, type='composite')
+def normalize_source_sink(spec):
Review Comment:
Branching is handled outside the `chain` transform where one names ones
inputs explicitly. FWIW, the way we handle different parsing is that we
delegate based on the type argument for the non-common parameters.
I like the idea of deferring magic to later. There is the question of
whether we call this `source/sink` vs `sources/sinks` (gets messy to accept
both, and we could do singular as multiple is probably the exceptional case)
and whether we accept/require a list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
