tvalentyn commented on a change in pull request #12318:
URL: https://github.com/apache/beam/pull/12318#discussion_r458253905
##########
File path: sdks/python/apache_beam/runners/portability/portable_runner_test.py
##########
@@ -284,6 +284,7 @@ def create_options(self):
return options
[email protected](sys.platform == "win32", reason="does not run on windows")
Review comment:
Can we add a TODO(BEAM-....) and include an error that happens in the
Jira? Does the error happen on all Python versions?
Similarly for other errors.
##########
File path: sdks/python/apache_beam/io/parquetio_test.py
##########
@@ -296,7 +296,9 @@ def test_sink_transform_int96(self):
path, self.SCHEMA96, num_shards=1, shard_name_template='')
def test_sink_transform(self):
- with tempfile.NamedTemporaryFile() as dst:
+ dst = tempfile.NamedTemporaryFile()
Review comment:
+1, this pattern (here and elsewhere) looks strange to me.
##########
File path: sdks/python/apache_beam/runners/worker/log_handler_test.py
##########
@@ -87,7 +87,8 @@ def _verify_fn_log_handler(self, num_log_entries):
self.assertEqual(
'%s: %s' % (msg, num_received_log_entries), log_entry.message)
self.assertTrue(
- re.match(r'.*/log_handler_test.py:\d+', log_entry.log_location),
+ re.match(
+ r'.*(/|\\)log_handler_test.py:\d+', log_entry.log_location),
Review comment:
Use `os.path.sep`.
##########
File path: sdks/python/apache_beam/runners/portability/stager_test.py
##########
@@ -167,6 +167,9 @@ def test_no_main_session(self):
# xdist adds unpicklable modules to the main session.
@pytest.mark.no_xdist
+ @pytest.mark.skip(
+ sys.platform == 'win32',
+ "Windows raise TypeError: can't pickle zipimport.zipimporter objects")
Review comment:
Is there a bug in dill or cpython pickle that tracks this problem? Does
this fail on all Python versions?
##########
File path: sdks/python/apache_beam/testing/datatype_inference_test.py
##########
@@ -174,6 +175,9 @@ def test_infer_typehints_schema(self, _, data, schema):
@parameterized.expand([(d["name"], d["data"], d["pyarrow_schema"])
for d in TEST_DATA])
@unittest.skipIf(pa is None, "PyArrow is not installed")
+ @unittest.skipIf(
+ sys.platform == "win32",
+ "numpy array dtype is coming as int32 by default in a windows 64 bit")
Review comment:
How does this test fail? We need a JIRA so that we understand the
implications of this for the users? Does this fail on all Python versions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
