TobKed commented on a change in pull request #12318:
URL: https://github.com/apache/beam/pull/12318#discussion_r459376217
##########
File path: .github/workflows/build_wheels.yml
##########
@@ -193,29 +196,232 @@ jobs:
GITHUB_BASE_REF=$GITHUB_BASE_REF
EOF
echo $(cat github_action_info)
- gsutil cp -a public-read github_action_info ${{ env.GCP_PATH }}
+ gsutil cp -a public-read github_action_info ${{
env.GCP_WHEELS_STAGING_PATH }}
- name: Upload GitHub event file to GCS bucket
- run: gsutil cp -a public-read ${GITHUB_EVENT_PATH} ${{ env.GCP_PATH }}
+ run: gsutil cp -a public-read ${GITHUB_EVENT_PATH} ${{
env.GCP_WHEELS_STAGING_PATH }}
list_files_on_gcs:
name: List files on Google Cloud Storage Bucket
- needs: upload_wheels_to_gcs
+ needs: upload_python_sdk_wheels_to_gcs
runs-on: ubuntu-latest
- if: github.repository_owner == 'apache' && github.event_name !=
'pull_request'
+ if: github.repository_owner == 'apache' && (github.event_name == 'push' ||
github.event_name == 'schedule')
steps:
- name: Authenticate on GCP
uses: GoogleCloudPlatform/github-actions/setup-gcloud@master
with:
service_account_email: ${{ secrets.GCP_SA_EMAIL }}
service_account_key: ${{ secrets.GCP_SA_KEY }}
- name: List file on Google Cloud Storage Bucket
- run: gsutil ls "${{ env.GCP_PATH }}*"
+ run: gsutil ls "${{ env.GCP_WHEELS_STAGING_PATH }}*"
+
+ python_unit_tests:
+ name: 'Python Unit Tests'
+ runs-on: ${{ matrix.os }}
+ if: github.event_name == 'push' || github.event_name == 'schedule'
Review comment:
> Question: Do we want to run on this on every push? This might have
quite a bit of overlap with precommits and might be slow.
push event is limited only to master and release-* branches so I think it
shouldn't overlap with precommits.
> Also, are actions workflow subject to any kind of quota? Are we at risk of
exceeding it? Can we monitor it somehow?
Quoting docs: "GitHub Actions usage is free for public repositories." so I
suppose there is no quota for the time. There are usage limits for concurrent
jobs but I think it should be not a problem since Apache has Enterprise plan (I
couldn't find official info anywhere)
docs:
https://docs.github.com/en/actions/getting-started-with-github-actions/about-github-actions#usage-limits
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
