riteshghorse commented on code in PR #26101:
URL: https://github.com/apache/beam/pull/26101#discussion_r1178196901
##########
sdks/go/pkg/beam/core/runtime/exec/datasource.go:
##########
@@ -263,8 +263,17 @@ func (n *DataSource) Process(ctx context.Context)
([]*Checkpoint, error) {
}
},
func(bcr *byteCountReader, ptransformID, timerFamilyID string)
error {
- tmap, err := decodeTimer(cp, wc, bcr)
- log.Infof(ctx, "DEBUGLOG: timer received for: %v and %v
- %+v err: %v", ptransformID, timerFamilyID, tmap, err)
+ dc := MakeElementDecoder(coder.SkipW(c).Components[0])
+ tmap, err := decodeTimer(dc, wc, bcr)
+ if err != nil {
+ return errors.WithContext(err, "error decoding
timer in datasource")
+ }
+ if fn, ok :=
n.OnTimerTransforms[ptransformID].Fn.OnTimerFn(); ok {
+ _, err :=
n.OnTimerTransforms[ptransformID].InvokeTimerFn(ctx, fn, timerFamilyID, tmap)
+ if err != nil {
+ return errors.WithContext(err, "ontimer
callback invocation failed")
+ }
+ }
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
