riteshghorse commented on code in PR #26101:
URL: https://github.com/apache/beam/pull/26101#discussion_r1179375418
##########
sdks/go/pkg/beam/core/runtime/exec/translate.go:
##########
@@ -588,6 +592,20 @@ func (b *builder) makeLink(from string, id linkID) (Node,
error) {
}
}
+ if len(userTimers) > 0 {
+ log.Debugf(context.TODO(),
"userTimers %+v", userTimers)
+ timerIDToCoder :=
make(map[string]*coder.Coder)
+ sID := StreamID{Port: Port{URL:
b.desc.GetTimerApiServiceDescriptor().GetUrl()}, PtransformID: id.to}
+ ec, wc, err :=
b.makeCoderForPCollection(input[0])
+ if err != nil {
+ return nil, err
+ }
+ for key := range userTimers {
+ timerIDToCoder[key] =
coder.NewT(ec, wc)
+ }
Review Comment:
Good catch, I agree. We should just send the key coder from here which then
simplifies the exec/coder.go for timer encoding/decoding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
