Abacn commented on code in PR #26474:
URL: https://github.com/apache/beam/pull/26474#discussion_r1180751916
##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcSchemaIOProvider.java:
##########
@@ -202,11 +204,14 @@ protected JdbcIO.DataSourceConfiguration
getDataSourceConfiguration() {
dataSourceConfiguration =
dataSourceConfiguration.withConnectionInitSqls(initSqls);
}
- if (config.getSchema().hasField("maxConnections")) {
- @Nullable Integer maxConnections = config.getInt32("maxConnections");
- if (maxConnections != null) {
- dataSourceConfiguration =
dataSourceConfiguration.withMaxConnections(maxConnections);
- }
+ @Nullable Integer maxConnections = config.getInt32("maxConnections");
Review Comment:
I see, the actual breaking change happens here. This if clause is removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
