Abacn commented on code in PR #26474:
URL: https://github.com/apache/beam/pull/26474#discussion_r1180820688
##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcSchemaIOProvider.java:
##########
@@ -67,6 +67,8 @@ public Schema configurationSchema() {
.addNullableField("fetchSize", FieldType.INT16)
.addNullableField("outputParallelization", FieldType.BOOLEAN)
.addNullableField("autosharding", FieldType.BOOLEAN)
+ .addNullableField("maxConnections", FieldType.INT16)
Review Comment:
I see, I think I find the cause. Here maxConnections is "FieldType.INT16"
but in jdbc.py it is "typing.Optional[int]". This configuration gets encoded by
ShortCoder then decode with VarIntCoder and data corruption happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
