ahmedabu98 commented on code in PR #26562:
URL: https://github.com/apache/beam/pull/26562#discussion_r1187666336
##########
.test-infra/jenkins/PostcommitJobBuilder.groovy:
##########
@@ -57,8 +60,15 @@ class PostcommitJobBuilder {
}
void defineAutoPostCommitJob(name) {
+ // default build schedule
+ String buildSchedule = 'H H/6 * * *'
+ try {
+ buildSchedule = scope.getProperty('buildSchedule')
+ } catch (MissingPropertyException ignored) {
+ // do nothing
+ }
Review Comment:
Makes sense, thanks for the explanation. Have you considered defining the
value inside the closure? So as to be accessed with
`jobDefinition.buildSchedule`? I just haven't seen a variable declared like
this before in our repo and don't know if there's any downsides to it.
Up to you, I'll defer to your judgement here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
