Abacn commented on code in PR #26562:
URL: https://github.com/apache/beam/pull/26562#discussion_r1187683226
##########
.test-infra/jenkins/PostcommitJobBuilder.groovy:
##########
@@ -57,8 +60,15 @@ class PostcommitJobBuilder {
}
void defineAutoPostCommitJob(name) {
+ // default build schedule
+ String buildSchedule = 'H H/6 * * *'
+ try {
+ buildSchedule = scope.getProperty('buildSchedule')
+ } catch (MissingPropertyException ignored) {
+ // do nothing
+ }
Review Comment:
yeah, ideally PostcommitJobBuilder should just be designed as
PrecommitJobBuilder where parameters can be set as a map-like constructor (as
precommit job DSLs) then I would just need to add one more parameter there.
However currently PostcommitJobBuilder does not quite follow a Builder pattern.
Both constructor and its static method (postCommitJob) are used for assembling
postcommit jobs. Opened #26588 addressing this as a future task
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
