kennknowles commented on a change in pull request #12366:
URL: https://github.com/apache/beam/pull/12366#discussion_r460357318
##########
File path:
sdks/java/extensions/sql/datacatalog/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/datacatalog/DataCatalogBigQueryIT.java
##########
@@ -66,12 +66,15 @@
});
}
+ @SuppressWarnings("initialization.fields.uninitialized")
@Parameterized.Parameter(0)
public String dialectName;
+ @SuppressWarnings("initialization.fields.uninitialized")
@Parameterized.Parameter(1)
public Class<? extends QueryPlanner> queryPlanner;
+ @SuppressWarnings("nullness")
Review comment:
Maybe... in this case I realize that the string is probably used to
create a planner by reflection. I don't know if that will work. If it does,
then that is great. If it does not work, then you'll want to check for null and
throw an exception. I've created a new Beam module to make this easy:
`org.apache.beam.sdk.utils.Preconditions.checkArgumentNotNull` returns a
non-nullable value after checking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
