jayendra13 commented on a change in pull request #12366:
URL: https://github.com/apache/beam/pull/12366#discussion_r460366521
##########
File path:
sdks/java/extensions/sql/datacatalog/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/datacatalog/DataCatalogBigQueryIT.java
##########
@@ -66,12 +66,15 @@
});
}
+ @SuppressWarnings("initialization.fields.uninitialized")
@Parameterized.Parameter(0)
public String dialectName;
+ @SuppressWarnings("initialization.fields.uninitialized")
@Parameterized.Parameter(1)
public Class<? extends QueryPlanner> queryPlanner;
+ @SuppressWarnings("nullness")
Review comment:
Using `checkArgumentNotNull `
```
readPipeline
.getOptions()
.as(BeamSqlPipelineOptions.class)
.setPlannerName(checkArgumentNotNull(queryPlanner.getCanonicalName()));
```
throws
```
/home/jayendra/beam/sdks/java/extensions/sql/datacatalog/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/datacatalog/DataCatalogBigQueryIT.java:101:
error: [flowexpr.parse.error.postcondition] error parsing the postcondition
expression for checkArgumentNotNull(T)
.setPlannerName(checkArgumentNotNull(queryPlanner.getCanonicalName()));
^
cannot parse the expression Invalid 'reference' because identifier not
found
```
Which seems to be related to
https://github.com/typetools/checker-framework/issues/752 .
I checked the other places in the code where `checkArgumentNotNull` has been
used, all the uses are under the `runner.dataflow` package where null-cheking
has not been applied yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
