rshamunov commented on code in PR #26513:
URL: https://github.com/apache/beam/pull/26513#discussion_r1191015480
##########
playground/terraform/infrastructure/cloudbuild-manual-setup/README.md:
##########
@@ -31,18 +31,51 @@ Cloud Build triggers created by terraform scripts from this
directory automate s
- Cloud Build Editor
- Security Admin
- Service Account User
+ - Secret Manager Admin
- [gcloud CLI](https://cloud.google.com/sdk/docs/install-sdk)
-- An existing GCP Bucket to save Terraform state - `state-bucket`
+- An existing GCS Bucket to save Terraform state for Cloud Build triggers
<triggers-state-bucket>
+- An existing GCS Bucket to store private Cloud Build logs
<private-logs-bucket>
+- An existing GCS Bucket to store public Cloud Build logs <public-logs-bucket>
- DNS name for your Playground deployment instance
- [Terraform](https://www.terraform.io/)
+- [GitHub Personal Access
Token](https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/creating-a-personal-access-token)
- [Apache Beam GitHub](https://github.com/apache/beam) repository cloned
locally
## 1. Set up the Google Cloud Build for your GCP project
-The `playground/terraform/infrastructure/cloudbuild-manual-setup/01.setup`
provisions dependencies required to set up Cloud Build for Playground:
+First provide the variables by creating a `common.tfvars`
+```
+beam/playground/terraform/infrastructure/cloudbuild-manual-setup/common.tfvars
+```
+And put the following:
+```
+playground_deploy_sa = "DEPLOY_SA_NAME" # SA name used for Deploy trigger
+playground_update_sa = "UPDATE_SA_NAME" # SA name used for Update trigger
+playground_ci_sa = "CI_SA_NAME" # SA name used for CI trigger
+playground_cd_sa = "CD_SA_NAME" # SA name used for CD trigger
+project_id = "PROJECT_ID" # ID of the project used
+playground_environment_name = "environment" # Name of the environment. Used
for prefixing (dev- stag- prod- etc.)
Review Comment:
Don't request env specific variables. Set default values instead (in
variables.tf?):
playground_environment_name=env
playground_dns_name=fqdn.playground.zone
image_tag=env-1.0
playground_region=us-central1
playground_zone=us-central1-a
skip_appengine_deploy=false
state_bucket=playground-tfstate-project-env
terraform_source_repo=https://github.com/apache/beam
terraform_source_branch=master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
