olehborysevych commented on code in PR #26513:
URL: https://github.com/apache/beam/pull/26513#discussion_r1196362209
##########
playground/terraform/infrastructure/cloudbuild-manual-setup/02.builders/variables.tf:
##########
@@ -16,93 +16,149 @@
# under the License.
variable "project_id" {
- type = string
description = "The ID of the Google Cloud project within which resources are
provisioned"
}
-variable "region" {
- type = string
- description = "The Google Cloud Platform (GCP) region (For example:
us-central1) where Cloud Build triggers will be created at"
-}
-
-variable "infra_trigger_name" {
- type = string
+variable "pg_infra_trigger_name" {
description = "The name of the trigger that will deploy Playground
infrastructure"
- default = "playground-infrastructure-trigger"
+ default = "Initialize-Playground-environment"
}
-variable "gke_trigger_name" {
- type = string
+variable "pg_gke_trigger_name" {
description = "The name of the trigger that will deploy Playground to GKE"
- default = "playground-to-gke-trigger"
+ default = "Deploy-Update-Playground-environment"
+}
+variable "pg_ci_trigger_name" {
+ description = "The name of the trigger to run CI checks"
+ default = "Playground-CI-stable"
}
-variable "cloudbuild_service_account_id" {
- type = string
- description = "The ID of the cloud build service account responsible for
provisioning Google Cloud resources"
- default = "playground-cloudbuild-sa"
+variable "pg_cd_trigger_name" {
+ description = "The name of the trigger to run CD checks"
+ default = "Playground-CD-stable"
}
-variable "github_repository_name" {
- type = string
- description = "The name of the GitHub repository. For example the repository
name for https://github.com/example/foo is 'foo'."
+variable "playground_deploy_sa" {
+ description = "The ID of the cloud build service account responsible for
deploying the Playground"
}
-variable "github_repository_owner" {
- type = string
- description = "The owner of the GitHub repository. For example the owner for
https://github.com/example/foo is 'example'."
+variable "playground_update_sa" {
+ description = "The ID of the cloud build service account responsible for
updating the Helm"
}
-variable "github_repository_branch" {
- type = string
- description = "The GitHub repository branch regex to match cloud build
trigger"
+variable "playground_ci_sa" {
+ description = "The ID of the cloud build service account responsible for
running CI checks and scripts"
}
+variable "playground_cd_sa" {
+ description = "The ID of the cloud build service account responsible for
running CD checks and scripts"
+}
+
variable "playground_environment_name" {
- description = <<EOF
-Environment name where to deploy Playground. Located in
playground/terraform/environment/{environment_name}. E.g. test, dev, prod.
-More details:
https://github.com/akvelon/beam/blob/cloudbuild%2Bmanualsetup%2Bplayground/playground/terraform/README.md#prepare-deployment-configuration";
- EOF
+ description = "An environment name which will have it is own configuration
of Playground"
+ default = "env"
}
variable "playground_dns_name" {
- description = <<EOF
-The DNS record name for Playground website.
-More details:
https://github.com/apache/beam/blob/master/playground/terraform/README.md#deploy-playground-infrastructure";
- EOF
+ description = "The DNS A-record name for Playground website"
+ default = "fqdn.playground.zone"
}
-variable "playground_network_name" {
- description = "The Google Cloud Platform (GCP) VPC Network Name for
Playground deployment"
+variable "state_bucket" {
+ description = "The Google Cloud Platform GCS bucket name for Playground
Terraform state file"
+ default = "playground-tfstate-project-env"
}
-variable "playground_gke_name" {
- description = "The Playground GKE Cluster name in Google Cloud Platform
(GCP)"
+variable "cloudbuild_bucket_private" {
+ description = "The Google Cloud Platform GCS bucket name for Playground
Cloudbuild Private logs"
}
-variable "state_bucket" {
- description = "The Google Cloud Platform (GCP) GCS bucket name for Beam
Playground temp files and Terraform state"
+variable "cloudbuild_bucket_public" {
+ description = "The Google Cloud Platform GCS bucket name for Playground
Cloudbuild Private logs"
Review Comment:
should be "Public" @rshamunov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
