johnjcasey commented on code in PR #26714:
URL: https://github.com/apache/beam/pull/26714#discussion_r1195239450
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java:
##########
@@ -571,7 +571,7 @@ long flush(
failedRow,
error.getRowIndexToErrorMessage().get(failedIndex)),
timestamp);
} catch (InvalidProtocolBufferException e) {
- LOG.error("Failed to insert row and could not parse the
result!");
+ LOG.error("Failed to insert row and could not parse the
result!", e);
Review Comment:
I think both of these need to rethrow the exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
