bvolpato commented on code in PR #26714:
URL: https://github.com/apache/beam/pull/26714#discussion_r1195906446


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java:
##########
@@ -571,7 +571,7 @@ long flush(
                             failedRow, 
error.getRowIndexToErrorMessage().get(failedIndex)),
                         timestamp);
                   } catch (InvalidProtocolBufferException e) {
-                    LOG.error("Failed to insert row and could not parse the 
result!");
+                    LOG.error("Failed to insert row and could not parse the 
result!", e);

Review Comment:
   Thanks for the context @reuvenlax. Probably having the exception spit out 
would help in understanding the context, so this change should be still worth 
pushing through, what do you think?
   
   All we know today is that it's a `InvalidProtocolBufferException`, so I'm 
hoping to get more information (we could likely ask the user who got in this 
situation to use a snapshot, as they have been responsive).
   
   I will try to reproduce this locally.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to