Abacn commented on code in PR #26557:
URL: https://github.com/apache/beam/pull/26557#discussion_r1195288700
##########
sdks/java/io/hadoop-format/src/test/java/org/apache/beam/sdk/io/hadoop/format/HadoopFormatIOReadTest.java:
##########
@@ -1076,6 +1080,16 @@ private static SerializableConfiguration
loadTestConfiguration(
return new SerializableConfiguration(conf);
}
+ private static SerializableConfiguration loadTestConfigurationWithInputPath(
Review Comment:
For generosity we could make this as another overload method of
`loadTestConfiguration` having an additional signature of Map<String, String>,
and set these configuration by `conf.set(k, v)` inside the method
##########
sdks/java/io/hadoop-format/src/main/java/org/apache/beam/sdk/io/hadoop/format/HadoopFormatIO.java:
##########
@@ -702,6 +702,11 @@ public void populateDisplayData(DisplayData.Builder
builder) {
"mapreduce.job.inputformat.class",
hadoopConfig.get("mapreduce.job.inputformat.class"))
.withLabel("InputFormat Class"));
+ builder.addIfNotNull(
+ DisplayData.item(
+ "mapreduce.input.fileinputformat.inputdir",
+
hadoopConfig.get("mapreduce.input.fileinputformat.inputdir"))
Review Comment:
Yeah, sounds good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
