Abacn commented on code in PR #26557:
URL: https://github.com/apache/beam/pull/26557#discussion_r1202501376
##########
sdks/java/io/hadoop-format/src/main/java/org/apache/beam/sdk/io/hadoop/format/HadoopFormatIO.java:
##########
@@ -702,6 +702,15 @@ public void populateDisplayData(DisplayData.Builder
builder) {
"mapreduce.job.inputformat.class",
hadoopConfig.get("mapreduce.job.inputformat.class"))
.withLabel("InputFormat Class"));
+ final String inputDir =
hadoopConfig.get("mapreduce.input.fileinputformat.inputdir");
+ if (inputDir != null) {
+ builder.add(
+ DisplayData.item(
+ "mapreduce.input.fileinputformat.inputdir",
+ String.format(
+ "%s...", inputDir.substring(0,
Math.min(inputDir.length(), 250))))
Review Comment:
Could import `import
org.apache.beam.repackaged.core.org.apache.commons.lang3.StringUtils;`
which uses the dependency that shaded in java-core so no need to include new
dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
