manavgarg commented on code in PR #27020:
URL: https://github.com/apache/beam/pull/27020#discussion_r1219092588
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/providers/BigQueryStorageWriteApiSchemaTransformProvider.java:
##########
@@ -114,7 +114,7 @@ public List<String> inputCollectionNames() {
@Override
public List<String> outputCollectionNames() {
- return Arrays.asList(FAILED_ROWS_TAG, FAILED_ROWS_WITH_ERRORS_TAG);
+ return Arrays.asList(FAILED_ROWS_TAG, FAILED_ROWS_WITH_ERRORS_TAG,
"errors");
Review Comment:
Is anyone using this "FAILED_ROWS_WITH_ERRORS_TAG" or "FAILED_ROWS_TAG" ? If
not, can we just consolidate and have one name going forward. This would make
it more consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
