Dippatel98 commented on code in PR #27020:
URL: https://github.com/apache/beam/pull/27020#discussion_r1231392403
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/providers/BigQueryStorageWriteApiSchemaTransformProvider.java:
##########
@@ -371,7 +371,8 @@ public PCollectionRowTuple expand(PCollectionRowTuple
input) {
.setRowSchema(rowSchema);
return PCollectionRowTuple.of(FAILED_ROWS_TAG, failedRowsOutput)
- .and(FAILED_ROWS_WITH_ERRORS_TAG, failedRowsWithErrors);
+ .and(FAILED_ROWS_WITH_ERRORS_TAG, failedRowsWithErrors)
+ .and("errors", failedRowsWithErrors);
Review Comment:
Hey @johnjcasey, I was looking into this. It looks like PCollectionRowTuple
only supports String tags, the method does not have support for TupleTags. That
might be the reason these were implemented with Strings in the first place.
https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/values/PCollectionRowTuple.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
