nickuncaged1201 commented on code in PR #27039:
URL: https://github.com/apache/beam/pull/27039#discussion_r1231374350
##########
sdks/java/io/file-schema-transform/src/main/java/org/apache/beam/sdk/io/fileschematransform/CsvWriteSchemaTransformFormatProvider.java:
##########
@@ -83,9 +85,11 @@ public PCollection<String> expand(PCollection<Row> input) {
}
WriteFilesResult<String> result = input.apply("Row to CSV", write);
- return result
- .getPerDestinationOutputFilenames()
- .apply("perDestinationOutputFilenames", Values.create());
+ PCollection<String> output =
+ result
+ .getPerDestinationOutputFilenames()
+ .apply("perDestinationOutputFilenames", Values.create());
+ return PCollectionTuple.of(RESULT_TAG, output);
Review Comment:
As in the previous note, CsvWriteIO itself doesn't expose any error. All
other transforms have some sort of conversion step, while CSV write doesn't. So
nothing can be done about this really.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
